-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EQL: multi-value fields support #76610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add multi-valued fields support. Part 1 - remove in-place optimizations (ranges, binary comparisons, negation logic) - functions support for different values of the same field in multi-use scenarios - null handling - negation handling
…o eql_multi_value_fields
…76605) Adds backwards compatibility checks and tests for multi-value fields support
…o eql_multi_value_fields
elasticmachine
added
the
Team:QL (Deprecated)
Meta label for query languages team
label
Aug 17, 2021
Pinging @elastic/es-ql (Team:QL) |
Luegg
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Aug 17, 2021
Adds multi-valued fields support: - remove in-place optimizations (ranges, binary comparisons, negation logic) - functions support for different values of the same field in multi-use scenarios - null handling - negation handling - backwards compatibility checks and tests for multi-value fields support (cherry picked from commit 0c2c93e)
astefan
changed the title
EQL: mulit-value fields support
EQL: multi-value fields support
Aug 17, 2021
astefan
added a commit
that referenced
this pull request
Aug 17, 2021
* EQL: mulit-value fields support (#76610) Adds multi-valued fields support: - remove in-place optimizations (ranges, binary comparisons, negation logic) - functions support for different values of the same field in multi-use scenarios - null handling - negation handling - backwards compatibility checks and tests for multi-value fields support (cherry picked from commit 0c2c93e)
jrodewig
added a commit
that referenced
this pull request
Aug 19, 2021
Changes: * Removes the limitation for multi-value fields. * Adds a recommendation to avoid complex expressions for Boolean comparisons to the `string` fn. Relates to #76610.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 19, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 19, 2021
danhermann
pushed a commit
to danhermann/elasticsearch
that referenced
this pull request
Aug 19, 2021
Changes: * Removes the limitation for multi-value fields. * Adds a recommendation to avoid complex expressions for Boolean comparisons to the `string` fn. Relates to elastic#76610.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/EQL
EQL querying
>feature
Team:QL (Deprecated)
Meta label for query languages team
v7.15.0
v8.0.0-alpha2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces multi-value fields support in EQL queries:
A specific use-case that this PR doesn't cover: the
string
function with aboolean
parameter used with complex expressions as argument forstring
. Example:where string(fieldA > 2 and not fieldB < 2 or not concat(host_name, port) == "abc:123") == "true"
The code in this PR is part of a feature branch developed separately and is made of the following previously approved PRs: